From 59dfd3aab208ffc0345dd557d6682ba0753f58c1 Mon Sep 17 00:00:00 2001 From: Greg Brockman Date: Tue, 20 Jul 2010 00:46:21 -0400 Subject: [PATCH] Check size of path buffer before writing into it This prevents a buffer overrun that could otherwise be triggered by creating a file called '.git' with contents gitdir: (something really long) Signed-off-by: Greg Brockman Signed-off-by: Junio C Hamano (cherry picked from commit 3c9d0414ed2db0167e6c828b547be8fc9f88fccc) --- setup.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/setup.c b/setup.c index 5716d90..e70df0b 100644 --- a/setup.c +++ b/setup.c @@ -170,6 +170,8 @@ static int is_git_directory(const char *suspect) char path[PATH_MAX]; size_t len = strlen(suspect); + if (PATH_MAX <= len + strlen("/objects")) + die("Too long path: %.*s", 60, suspect); strcpy(path, suspect); if (getenv(DB_ENVIRONMENT)) { if (access(getenv(DB_ENVIRONMENT), X_OK)) -- 1.7.2